Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add websocket scheme support to HttpEnvironmentProxy.cs #32302

Merged
merged 1 commit into from
Feb 24, 2020
Merged

Add websocket scheme support to HttpEnvironmentProxy.cs #32302

merged 1 commit into from
Feb 24, 2020

Conversation

daddyman
Copy link
Contributor

Fixes #32230

Use insecure proxy (http_proxy) for schemes http and ws.
Use secure proxy (https_proxy) to schemes https and wss.

@daddyman
Fixes #32230
6f5825b 
Use insecure proxy (http_proxy) for schemes http and ws
Use secure proxy (https_proxy) to schemes https and wss
@dnfclas
Copy link

dnfclas commented Feb 14, 2020 •
edited
Loading

CLA assistant check
All CLA requirements met.

stephentoub
stephentoub approved these changes Feb 14, 2020
View reviewed changes
Copy link
Member

@stephentoub stephentoub left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@davidsh davidsh added this to the 5.0 milestone Feb 14, 2020
davidsh
davidsh approved these changes Feb 14, 2020
View reviewed changes
Copy link
Contributor

@davidsh davidsh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the PR!

@jaredpar jaredpar mentioned this pull request Feb 14, 2020
Closed
@davidsh
Copy link
Contributor

davidsh commented Feb 20, 2020

/azp list

@azure-pipelines
Copy link

CI/CD Pipelines for this repository:

@davidsh davidsh closed this Feb 20, 2020
@davidsh davidsh reopened this Feb 20, 2020
@davidsh
Copy link
Contributor

davidsh commented Feb 24, 2020

CI failures unrelated to PR.

@davidsh davidsh merged commit 67e9a10 into dotnet:master Feb 24, 2020
@daddyman daddyman deleted the issue_32230_websocketproxy branch February 25, 2020 02:32
@ghost ghost locked as resolved and limited conversation to collaborators Dec 10, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@mehulchandroliya mehulchandroliya mehulchandroliya requested changes

@stephentoub stephentoub stephentoub approved these changes

@scalablecory scalablecory scalablecory approved these changes

@davidsh davidsh davidsh approved these changes

Assignees
No one assigned
Labels
area-System.Net.Http
Projects
None yet
Milestone
5.0.0
Development

Successfully merging this pull request may close these issues.

ClientWebSocket on Linux uses wrong proxy if http and https proxies are different
7 participants
@daddyman @dnfclas @davidsh @stephentoub @scalablecory @mehulchandroliya @Dotnet-GitSync-Bot